Add primary keys to tables that don't have them #9363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some mysql clusters (like Percona-XtraDB-Cluster) prohibit the use of DML commands on a table. It's also just a good practice to add it.
Some mysql clusters (like Percona-XtraDB-Cluster) prohibit the use of DML commands on a table. It's also just a good practice to add it. See laravel/framework#15770
Some mysql clusters (like Percona-XtraDB-Cluster) prohibit the use of DML commands on a table. It's also just a good practice to add it.
13 tasks
|
We actually specifically do not use primary keys other than incrementing ids in Snipe-IT. We used to have them, but they caused HUGE amounts of problems as requirements and systems changed (stuff that used to not be nullable and had no value then became nullable, etc). If it will still work for your use-case without the |
snipe
added a commit
that referenced
this pull request
Apr 14, 2021
This reproduces #9363 without the PK in custom fields Signed-off-by: snipe <snipe@snipe.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds primary keys to tables where they are missing.
In short: Some database systems (like XtraDB cluster) require explicit primary keys for all tables, so this PR adds them to those that are missing them.
See laravel/framework#15770 for a thorough explanation and more context.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested on our environment where the migrations table was missing the
idcolumn (shows you we've been using this since at least 2016 😅 ) and with the default database you get when installing snipe itChecklist: